TextViewer: use Throttler for firePostSelectionChanged #1695 #1703
Conversation
|
Thanks @jukzi. Please extend the commit message, "immediately calls firePostSelectionChanged by chance." is not very telling. The project guidelines are that the commit message should describe the change and not the ticket. |
Test Results 917 files 917 suites 36m 6s ⏱️ For more details on these failures, see this check. Results for commit 1474134. ♻️ This comment has been updated with latest results. |
jukzi
force-pushed
the
TextViewer_use_Throttler
branch
from
7ff0111 to
dea25b2
Compare
done - good catch. |
done. ok? Otherwise please make a suggestion. |
jukzi
force-pushed
the
TextViewer_use_Throttler
branch
from
dea25b2 to
7abf4fa
Compare
...se.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/multipageeditor/MultiVariablePageTest.java
Outdated
Show resolved
Hide resolved
jukzi
force-pushed
the
TextViewer_use_Throttler
branch
from
7abf4fa to
2e1abe1
Compare
jukzi
force-pushed
the
TextViewer_use_Throttler
branch
from
2e1abe1 to
976f3c7
Compare
There was a problem hiding this comment.
Let's merge it as soon as CI pass so we get it in early in 4.32 to adapt if necessary.
(related) We should also consider, in a separate PR, changing the value of OpenStrategy.getPostSelectionDelay() to some duration that better matches "a bit more than the typical duration between 2 arrow keystorkes".
jukzi
force-pushed
the
TextViewer_use_Throttler
branch
from
7523d5b to
6eff201
Compare
…rm#1695 Avoids a 500ms delay after changing the selection, like higlighting the selected word. eclipse-platform#1695
jukzi
force-pushed
the
TextViewer_use_Throttler
branch
from
6eff201 to
1474134
Compare
Avoids a 500ms delay after changing the selection, like higlighting the
selected word.
#1695